# My Survey Form project - Please review + suggestions

**URL:** <https://group.classcentral.com/t/my-survey-form-project-please-review-suggestions/35796>\
**Category:** Web Development Bootcamp\
**Created:** [September 22, 2022, 6:41pm UTC](https://group.classcentral.com/t/my-survey-form-project-please-review-suggestions/35796 "2022-09-22T18:41:28Z")\
**Posts on this page:** 6\
**Page:** 1

<div class="post-metadata">

**Author:** ![janhavi04n](https://avatars.discourse-cdn.com/v4/letter/j/e95f7d/32.png) [@janhavi04n](https://group.classcentral.com/u/janhavi04n)\
**Post date:** [September 22, 2022, 6:41pm UTC](https://group.classcentral.com/t/my-survey-form-project-please-review-suggestions/35796/1 "2022-09-22T18:41:28Z")

</div>

Hello Everyone.

Finally managed to complete the Survey Form project. I have created a repo [here](https://github.com/janhavi04n/freecodecamp-webdesign)

And the survey form is hosted on github pages here → [Survey Form](https://janhavi04n.github.io/freecodecamp-webdesign/survey_form.html)

Still a long long way to go. Comments/suggestions would be really helpful.

Thank you!

---

<div class="post-metadata">

**Author:** ![Domi](https://sea2.discourse-cdn.com/flex016/user_avatar/group.classcentral.com/domi/32/5810_2.png) [@Domi](https://group.classcentral.com/u/Domi)\
**Post date:** [September 23, 2022, 7:22am UTC](https://group.classcentral.com/t/my-survey-form-project-please-review-suggestions/35796/2 "2022-09-23T07:22:26Z")

</div>

Hey, it looks good!  
I really like how the button changes when you click it, well done 🙂  
Since you asked for comments and suggeststions, I have two:

1. see how it looks on a mobile devide - I think it doesn’t have enough room at the top, it’s too close to the border.

2. your input fields are overflowing the container, like this:  
 ![image](https://us1.discourse-cdn.com/flex016/uploads/ccstudygroup/original/2X/d/dba29f01912a7e3ca9bc36d0991585a643d70871.png)  
there’s a fix for this: [box-sizing - CSS: Cascading Style Sheets | MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing)

---

<div class="post-metadata">

**Author:** ![janhavi04n](https://avatars.discourse-cdn.com/v4/letter/j/e95f7d/32.png) [@janhavi04n](https://group.classcentral.com/u/janhavi04n)\
**Post date:** [September 25, 2022, 7:46am UTC](https://group.classcentral.com/t/my-survey-form-project-please-review-suggestions/35796/3 "2022-09-25T07:46:10Z")

</div>

Thank you 🙂

Tried opening the form on a mobile and yes does need the changes. Thanks for sharing CSS box-sizing link.

---

<div class="post-metadata">

**Author:** ![carlost2672543](https://sea2.discourse-cdn.com/flex016/user_avatar/group.classcentral.com/carlost2672543/32/4162_2.png) [@carlost2672543](https://group.classcentral.com/u/carlost2672543)\
**Post date:** [September 26, 2022, 3:26pm UTC](https://group.classcentral.com/t/my-survey-form-project-please-review-suggestions/35796/4 "2022-09-26T15:26:17Z")

</div>

Hi @janhavi04n

This is my feedback, take this as a few ideas, it might help or not, remember that the final decision is yours. 😉

You `html` needs a `lang` attribute because accessibility and SEO. Better work with browsers not against it.

Your head needs:

`<meta name="viewport" content="width=device-width, initial-scale=1.0">`

to look better in smaller devices and not like a tiny page inside my phone. 😋

It think is better to put our css as the last link, just in case you want to use an external one; to make sure that everything is load if your CSS stylesheet needs to use it, Google Fonts for example.

Right now it seems like `body` doesn’t need `width` and `height` because its content is bigger than does dimensiones, check if you need those CSS properties, maybe just `max-width: 100vw;` it would be enough at the end. It depends of your final layout.

I think your `h1` will look better with a bigger `font-size` and your page sections could have a bit more spacing between then (more white spaces). After spacing your fieldsets maybe your bottom lines won’t look good enough, consider `outline` CSS property to get the same design or the ::after pseudo element to create that line, for example.

Your fieldsets should use `legend` tag instead label one.

Finally, your `submit` button should have a color that stands out; it is a call to action so everyone should see it at first look.

About colors… be consistent, try to use the same units throw your page. Better don’t use keyword colors. Also I think it is better to use colors similar to black or white, but not those ones.

Related with colors: remember to check if your text is easy to read. Consider contrast, fonts, `line-height` and `word-spacing` and `word-break`, for example. Don’t forget to google things like html checker, css checker, accessibility checker or contrast checker. Here you have [the WebAIM Contrast Checker](https://webaim.org/resources/contrastchecker/), for example.

I hope this helps.

Great job Janhavi!! Your nearly have got it.

Happy coding!

---

<div class="post-metadata">

**Author:** ![janhavi04n](https://avatars.discourse-cdn.com/v4/letter/j/e95f7d/32.png) [@janhavi04n](https://group.classcentral.com/u/janhavi04n)\
**Post date:** [September 26, 2022, 5:05pm UTC](https://group.classcentral.com/t/my-survey-form-project-please-review-suggestions/35796/5 "2022-09-26T17:05:33Z")

</div>

Thanks Carlos T.

Busy week ahead but looks like my weekend is sorted now. Got some pointers by Dominika Wojewska as well.  
Lots to read and understand 🙂 but enjoying learning html and css.

---

<div class="post-metadata">

**Author:** ![system](https://us1.discourse-cdn.com/flex016/uploads/ccstudygroup/original/1X/36206832181ed26910a18e33d8bfef087cf661b1.svg) [@system](https://group.classcentral.com/u/system)\
**Post date:** [November 10, 2022, 5:06pm UTC](https://group.classcentral.com/t/my-survey-form-project-please-review-suggestions/35796/6 "2022-11-10T17:06:09Z")

</div>

This topic was automatically closed 45 days after the last reply. New replies are no longer allowed.
